-
Notifications
You must be signed in to change notification settings - Fork 308
feat: grouped pretty print status output #4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
320c852 to
ec80910
Compare
Pull Request Test Coverage Report for Build 18391266662Details
💛 - Coveralls |
9dcaefb to
6f6c541
Compare
6f6c541 to
3b1adbd
Compare
| github.com/mithrandie/csvq-driver v1.7.0 | ||
| github.com/muesli/reflow v0.3.0 | ||
| github.com/oapi-codegen/nullable v1.1.0 | ||
| github.com/olekukonko/tablewriter v1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently use markdown table renderer from bubbletea
Line 107 in 188a183
| func RenderTable(markdown string) error { |
Shall we stick with it for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sweatybridge dug into this a bit deeper and sadly it looks like the style options for the markdown rendering using that lib are a lot more limited. For example, there's no way to configure colspan (to make the header span multiple columns) or rounded corners, so the final output will be much more basic than the above screenshot.
If we're keen on limiting dependencies, I could attempt to render the above from scratch (but we'll likely have less flexibility in the future for things like word wrap).
This updates the pretty printed output from
supabase startandsupabase statusto be a bit more user friendly, especially for newcomers. Specifically:RESTandEdge FunctionsImplementation-wise I tried a few different table renderers (including manual), but
tablewriterended up being the most straightforward and least buggy.Testing
feat/pretty-print-output.go run . start- observe the new output.go run . statusto see the same output.